Skip to content

kola/qemu: Use max supported gic version on the aarch64 host #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 25, 2020
Merged

kola/qemu: Use max supported gic version on the aarch64 host #1286

openshift-merge-robot merged 1 commit into from
Mar 25, 2020

Conversation

@jcajka
Copy link
Collaborator

@jcajka jcajka commented Mar 25, 2020

Switching to version "max" will pick the highest correct version, allowing running test suite on wider range of aarch64 hosts.

@jcajka
kola/qemu: Use max supported gic version on the aarch64 host
4c4b761 
Switching to version "max" will pick the highest correct version, allowing running test suite on wider range of aarch64 hosts.
@cgwalters
Copy link
Member

cgwalters commented Mar 25, 2020

/approve
/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jcajka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d81e3c2 into coreos:master Mar 25, 2020
@cgwalters cgwalters mentioned this pull request Mar 25, 2020
Merged
@cgwalters
Copy link
Member

cgwalters commented Mar 25, 2020 •
edited
Loading

@jcajka
In the future can you add a newline between the commit subject and body? Without that sometimes git tooling will render them together, e.g. today I see

walters@toolbox ~/s/g/c/coreos-assembler> git reset --hard origin/master
HEAD is now at c2759d67 deps: Handle empty/no archful deps files correctly If no line is selected by grep, non-zero code is returned. Skip that deps file if is not needed on that arch, missing or zero lenght.

instead of

walters@toolbox ~/s/g/c/coreos-assembler> git reset --hard origin/master
HEAD is now at c2759d67 deps: Handle empty/no archful deps files correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arithx arithx Awaiting requested review from arithx

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

Assignees

@cgwalters cgwalters

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jcajka @cgwalters @openshift-ci-robot @openshift-merge-robot